Need help removing this for loop

5 Ansichten (letzte 30 Tage)
xtremecheez
xtremecheez am 14 Nov. 2017
Kommentiert: Andrei Bobrov am 14 Nov. 2017
This is the last step in vectorizing my code, but I just can't see how to get rid of the pesky for loop. Any assistance is appreciated.
I've replaced the variables with numbers for a more readable example.
%size(Cp) = [5,3,100]
%size(Tr) = [2e4,100]
A = zeros(5,2e4,100);
for ii = 1:100
A(:,:,ii) = Cp(:,Tr(:,ii),ii);
end
  1 Kommentar
Stephen23
Stephen23 am 14 Nov. 2017
Bearbeitet: Stephen23 am 14 Nov. 2017
"I just can't see how to get rid of the pesky for loop. Any assistance is appreciated."
Don't get rid of the loop. Using a loop is probably the neatest, clearest, and most efficient way to solve that task. Anything else will just pointlessly obfuscate your code and waste your time later when you forget what it does.

Melden Sie sich an, um zu kommentieren.

Akzeptierte Antwort

Walter Roberson
Walter Roberson am 14 Nov. 2017
If I got my calculations right, then:
A = Cp( bsxfun(@plus, (1:size(Cp,1)).', bsxfun(@plus, (Tr - 1) * size(Cp,1), ((1:size(Cp,3)-1) * size(Cp,1) * size(Cp,2)) ) );
This is difficult to read and difficult to write. I cannot recommend it unless perhaps run time is very important -- and even then considering the size of the internal matrices involved and the number of operations used to construct them, I would tend to doubt that it is more efficient.
Your existing code with a loop is easier to read and probably nearly as efficient, possibly more efficient.
This is one of those cases where the goal to "vectorize" requires constructing large intermediate arrays and use calculations that have no obvious meaning. Since typically more time is spent programming and debugging and documenting than is spent in execution of a program, it is unlikely that you would be gain anything meaningful by vectorization.
  2 Kommentare
Jan
Jan am 14 Nov. 2017
+1: The large intermediate index array is not efficient.
Walter Roberson
Walter Roberson am 14 Nov. 2017
I think I forgot a permute() around the second bsxfun()

Melden Sie sich an, um zu kommentieren.

Weitere Antworten (1)

Andrei Bobrov
Andrei Bobrov am 14 Nov. 2017
Bearbeitet: Andrei Bobrov am 14 Nov. 2017
[k,m,n] = size(Cp);
A = Cp((1:k)' + k*(permute(Tr,[3 1 2]) - 1)+reshape(0:n-1,1,1,[])*k*m);
  3 Kommentare
Walter Roberson
Walter Roberson am 14 Nov. 2017
It looks to me as if Andrei's code is for R2016b and later.
Andrei Bobrov
Andrei Bobrov am 14 Nov. 2017
Yes.

Melden Sie sich an, um zu kommentieren.

Kategorien

Mehr zu Programming finden Sie in Help Center und File Exchange

Community Treasure Hunt

Find the treasures in MATLAB Central and discover how the community can help you!

Start Hunting!

Translated by