Given an instance of a class (without knowing class name), how to call the constructor?

13 Ansichten (letzte 30 Tage)
I have made a minimal example trying to implement a clone method
classdef Person
properties
name;
id;
end
methods
% Constructor
function person = Person(name)
person.name = name;
person.id = Person.getID();
end
% simple function
function name = getName(person)
name = person.name;
end
% Simple method where Constructor is called
function person = clone(person)
%want to call Constructor so even clones get unique ID
person = Person(person.name);
end
end
methods (Static)
%assign personal id (simplified version)
function id = getID()
persistent max_personal_id;
if(isempty(max_personal_id))
max_personal_id = 0;
end
max_personal_id = max_personal_id+1;
id = max_personal_id;
end
end
end
Now I try to extend the class to another class with same constructor arguments, without having to reimplement the clone method
classdef FireMan < Person
methods
% Constructor
function person = FireMan(name)
person@Person(name);
end
function name = getName(person)
name = ['FireMan ',person.name];
end
end
end
But this does not give wanted functionality of the clone method as it
p = FireMan('Sam');
p.getName()
ans =
'FireMan Sam'
p.clone.getName()
ans =
'Sam'
This happens of course because I call the Person constructer in the clone method and not the Fireman Constructor
I could of course add something like this to every subclass.
function person = construct(~,name)
person = FireMan(name);
end
But I wonder if I could avoid changes in the subclass.

Akzeptierte Antwort

Sean de Wolski
Sean de Wolski am 18 Mär. 2019
Might you be interested in inheriting from matlab.mixin.Copyable which gives you a copy method?
  4 Kommentare
Martin Vatshelle
Martin Vatshelle am 18 Mär. 2019
This last was much easier to understand and can be applied in many other cases than just copying the object so this is exactly what I needed.
Thank you!

Melden Sie sich an, um zu kommentieren.

Weitere Antworten (2)

Guillaume
Guillaume am 18 Mär. 2019
As Sean said, you may want to inherit from matlab.mixin.Copyable instead of implementing your own cloning interface. However, this would force your class to be a handle class.
Regardless, if you want just one copyElement/clone method, then you need to use reflection to know the actual class of the object you're cloning. You'll have to use eval or feval to invoke the correct constructor. It's one of the rare cases where eval makes sense:
% Clone (or copyElement) method within the base class
function person = clone(person)
assert(isa(person, 'Person'), 'input must be of class Person or one of its derived class');
person = feval(class(person), person.name); %invoke actual constructor of the class (same name as the class)
end
Also, note that your clone method is flawed. It only works with scalar inputs. If your class is not designed to work with arrays of Person, then you need to document and prevent that (protected horzcat, vertcat and cat which error). matlab.mixin.Copyable hides the troubles of dealing with class arrays (CopyElement is invoked for each element of the array). If you allow arrays of persons, you may also want to look at matlab.mixin.Heterogeneous
  2 Kommentare
Martin Vatshelle
Martin Vatshelle am 18 Mär. 2019
Thanks, this is a good solution.
I know my Class don't work with arrays, but it was an attempt to make a minimal working example and not really the code I am working on.
My real code does extend matlab.mixin.Heterogeneous
I guess this is fairly equivalent to
str2func( class( p ) )
As suggested by Sean
Guillaume
Guillaume am 18 Mär. 2019
Yes, it's equivalent to str2func. It's probably more concise with feval.

Melden Sie sich an, um zu kommentieren.


Adam
Adam am 18 Mär. 2019
Since your class doesn't inherit from handle the assignment operator will give you a copy of the correct class. However, this won't call the constructor so you would not get a new id. However, if the id is the only thing you want to change you could just change your clone function to
% Simple method where Constructor is called
function newPerson = clone(person)
%want to call Constructor so even clones get unique ID
newPerson = person;
newPerson.id = Person.getID( );
end
  2 Kommentare
Martin Vatshelle
Martin Vatshelle am 18 Mär. 2019
Thanks for your help, I know this is one way to do it.
My problem with this is that I duplicate the code of the constructor.
clone is just one example how one might reuse the constructor, if one have many different functions calling the constructor I feel this practice makes it a bit harder to maintain the code.
Adam
Adam am 18 Mär. 2019
Well, I would probably put my constructor code into an initialise() function and call that where I needed, but I have also used the str2func appraoch discussed above.

Melden Sie sich an, um zu kommentieren.

Kategorien

Mehr zu Mathematics finden Sie in Help Center und File Exchange

Community Treasure Hunt

Find the treasures in MATLAB Central and discover how the community can help you!

Start Hunting!

Translated by