how to save every iteration into workspace

2 Ansichten (letzte 30 Tage)
tarek abousaleh
tarek abousaleh am 12 Mär. 2018
Bearbeitet: dpb am 12 Mär. 2018
my code would save just the last iteration.
for c=1:170
name1 = strcat(folder_name1,'/',filesStruct1(c).name);
alpha = (((double(dicomread(name1)).*pi)./(4096)) - (pi./2))
dicomwrite(alpha, (strcat('Results/',filesStruct1(c).name)));
can you please edit my code so it saves alpha 170 times with 170 different 256*240 matrices thanks in advance

Akzeptierte Antwort

Stephen23 am 12 Mär. 2018
Bearbeitet: Stephen23 am 12 Mär. 2018
Use fullfile rather than string concatenation. To store the imported images in a loop simply preallocate a cell array before the loop, and then use indexing:
N = 170;
C = cell(1,N);
for k = 1:N
name = fullfile(folder_name1,filesStruct1(c).name);
alpha = double(dicomread(name1))*pi/4096 - pi/2
dicomwrite(alpha, fullfile('Results',filesStruct1(c).name));
C{k} = alpha;
  3 Kommentare
dpb am 12 Mär. 2018
Hadn't researched the cell/structure array sufficiently. I had presumed they would be implemented more like a linked list than actual arrays and therefore "not so much" a performance hit. So OP needs to put an allocation step after determining the size in my above answer... :)

Melden Sie sich an, um zu kommentieren.

Weitere Antworten (2)

KL am 12 Mär. 2018
Bearbeitet: KL am 12 Mär. 2018
You're overwriting alpha during every iteration. Replace alpha with alpha(c) and then move the save command outside the loop.
  4 Kommentare
tarek abousaleh
tarek abousaleh am 12 Mär. 2018
it is still not working and i am getting an errorrror using dicom_prep_ImagePixel>getPixelStorage (line 204) Invalid datatype for image pixels.
Error in dicom_prep_ImagePixel (line 13) [ba, bs, hb, pr] = getPixelStorage(X, txfr, useExistingBitDepths, metadata, dictionary);
Error in dicom_prep_metadata (line 51) metadata = dicom_prep_ImagePixel(metadata, X, map, txfr, useMetadataBitDepths, dictionary);
Error in dicom_create_IOD (line 26) metadata = dicom_prep_metadata(IOD_UID, metadata, X, map, options.txfr, options.usemetadatabitdepths, dictionary);
Error in dicomwrite>write_message (line 271) [attrs, status] = dicom_create_IOD(SOP_UID, X, map, ...
Error in dicomwrite (line 208) [status, options] = write_message(X, filename, map, metadata, options);
Error in phase (line 43) dicomwrite(alpha, (strcat('Results/',filesStruct1(c).name)));

Melden Sie sich an, um zu kommentieren.

dpb am 12 Mär. 2018
Bearbeitet: dpb am 12 Mär. 2018
n=length(filesStruct1); % presuming filesStruct1 is returned from DIR()
alpha=cell(n,1); % listen to the pundits and preallocate even cell array :)
for c=1:n
name1 = fullfile(folder_name1,filesStruct1(c).name);
alpha{c} = double(dicomread(name1)*pi)/4096 - pi/2;
NB: the "curlies" {} to create cell array alpha.
Alternatively you could read the first to determine
[r,c]=size(alphaOne); % first in case possibly use differing size arrays
alpha=zeros(r,c,n); % preallocate a 3D array, put each into slice (plane)
alpha(:,:,1)=alphaOne); % save first
clear alphaOne % minor cleanup; don't need any longer
for c=2:n % now do the rest
alpha(:,:,c)= ........
This way one has a default double array instead of cell array so can save a dereferencing step in use or, depending on what is to be done, making calculations across the various planes is much simpler if that were to be wanted/required...

Community Treasure Hunt

Find the treasures in MATLAB Central and discover how the community can help you!

Start Hunting!

Translated by