How to speed up my code and improve/avoid for loop
Ältere Kommentare anzeigen
Dear all, that's my piece of code that works correctly but too slow.
T=rand(100000,1)-0.3;
eTG=zeros(size(T)); %set eTG(1)=0 and preallocate
for i=2:length(T)
eTG(i)=eTG(i-1)+T(i-1);
eTG(i(eTG(i)>0))=0;
end
Preallocation doesn't help and "run and time" tool shows that string
eTG(i(eTG(i)>0))=0;
eats 83% of the total time. Please give me your advices how to optimize this code. Are there any ways to vectorize this code and avoid loops at all?
5 Kommentare
per isakson
am 12 Okt. 2017
Given i is a scalar, what is
eTG(i(eTG(i)>0))=0
supposed to do?
Sergei Zhuravlev
am 12 Okt. 2017
Bearbeitet: Sergei Zhuravlev
am 12 Okt. 2017
Walter Roberson
am 12 Okt. 2017
Replace that with
eTG(i) = max(0, eTG(i));
Could you confirm that you want negative values to be left untouched, but positive values to be set to 0?
Sergei Zhuravlev
am 12 Okt. 2017
Bearbeitet: Sergei Zhuravlev
am 12 Okt. 2017
Walter Roberson
am 12 Okt. 2017
Dang, I got it wrong this time too. Yes, min(0, eTG(i)) if you want negative untouched and positive set to 0.
Antworten (1)
Sergei Zhuravlev
am 12 Okt. 2017
Bearbeitet: Sergei Zhuravlev
am 12 Okt. 2017
Kategorien
Mehr zu Parallel Computing Toolbox finden Sie in Hilfe-Center und File Exchange
Produkte
Community Treasure Hunt
Find the treasures in MATLAB Central and discover how the community can help you!
Start Hunting!